[PATCH] wifi: iwlwifi: pcie: add NULL check for trans->dbg.dest_tlv in dump_monitor
sunliming Thu, 6 Aug 2026 13:42:08 +0800
| Newsgroups | org.kernel.vger.linux-wireless,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260806054209.457073-1-sunliming> |
From: sunliming <[email protected]> Fix below smatch warnings: drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c:3527 iwl_trans_pcie_dump_monitor() error: we previously assumed 'trans->dbg.dest_tlv' could be null Fixes: c8a00a6e89ff ("wifi: iwlwifi: pcie: move generation specific files to a folder") Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Signed-off-by: sunliming <[email protected]> --- drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c index 28b276c65952..9cea0fe9e578 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c @@ -3516,7 +3516,8 @@ iwl_trans_pcie_dump_monitor(struct iwl_trans *trans, iwl_trans_pcie_read_mem(trans, base, fw_mon_data->data, monitor_len / sizeof(u32)); - } else if (trans->dbg.dest_tlv->monitor_mode == MARBH_MODE) { + } else if (trans->dbg.dest_tlv && + (trans->dbg.dest_tlv->monitor_mode == MARBH_MODE)) { monitor_len = iwl_trans_pci_dump_marbh_monitor(trans, fw_mon_data, -- 2.43.0