RE: [PATCH 3/4] wifi: rtw88: rtw8822c: switch to the kernel's sort() library

Ping-Ke Shih <[email protected]>
Newsgroups org.kernel.vger.linux-wireless,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Arsenii Pashchenko <[email protected]> wrote:
> Replace the custom, nested bubble-sort logic in rtw8822c_dac_iq_sort()
> and __rtw8822c_dac_iq_sort() with a call to the kernel's optimized
> heapsort implementation.
> 
> Implement a concise, localized s32 comparator. Since the previous
> patch already guarantees that input values are properly sign-extended
> into signed arrays, the custom circular index sorting rules completely
> disappear, trimming down lines of code.
> 
> Signed-off-by: Arsenii Pashchenko <[email protected]>

I think this patch is correct, but please use real hardware to verify please.
The calibration is very important to WiFi performance, and hard to find
a slight degrade (e.g. throughput degrade from 500Mbps to 480Mbps). 

Acked-by: Ping-Ke Shih <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.