RE: [PATCH 2/4] wifi: rtw88: rtw8822c: use sign_extend32 for DAC IQ validation

Ping-Ke Shih <[email protected]>
Newsgroups org.kernel.vger.linux-wireless,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
> >                         temp = rtw_read32_mask(rtwdev, 0x2dbc, 0x3fffff);
> > -                       iv[DACK_SN_8822C - 1] = (s32)((temp & 0x3ff000) >> 12);
> > -                       qv[DACK_SN_8822C - 1] = (s32)(temp & 0x3ff);
> > +                       iv[DACK_SN_8822C - 1] = sign_extend32((temp & 0x3ff000) >> 12, 9);
> > +                       qv[DACK_SN_8822C - 1] = sign_extend32(temp & 0x3ff, 9);
> 
> FIELD_GET_SIGNED()
> 
> Please use real hardware to verify the values.
> 

Consider the change of sign_extend32() again. The value is not the same
as before. So, if people run this intermediate patch, the result will be
wrong. Please think how to rearrange your changes.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.