Re: [PATCH ath-next v3 6/8] wifi: ath12k: track per-ring RX sent-to-stack count
Jeff Johnson <[email protected]>
| Newsgroups | org.kernel.vger.linux-wireless,org.infradead.lists.ath12k |
|---|---|
| Message-ID | <[email protected]> |
On 8/10/2026 7:44 AM, Pardeep Kaur wrote: > diff --git a/drivers/net/wireless/ath/ath12k/debugfs.c b/drivers/net/wireless/ath/ath12k/debugfs.c > index 34c605b609cb..55e3b411d108 100644 > --- a/drivers/net/wireless/ath/ath12k/debugfs.c > +++ b/drivers/net/wireless/ath/ath12k/debugfs.c > @@ -1122,6 +1122,16 @@ static ssize_t ath12k_debugfs_dump_device_dp_stats(struct file *file, > len += scnprintf(buf + len, size - len, "%s: %u\n", > wbm_rx_drop[i], device_stats->wbm_err.drop[i]); > > + len += scnprintf(buf + len, size - len, "\nREO sent to stack\n"); My review agent notes: **Missing colon in section header.** `"\nREO sent to stack\n"` is inconsistent with every other section in `ath12k_debugfs_dump_device_dp_stats()`, all of which end with `:\n` (e.g., `"\nREO Rx Received:\n"`, `"\nHAL REO errors:\n"`, `"\nWBM Rx Drop Count:\n"`). Should be `"\nREO sent to stack:\n"`.