Re: [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address
Arend van Spriel <[email protected]>
| Newsgroups | org.kernel.vger.linux-wireless,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 11/08/2026 21:28, Rosen Penev wrote:
> The nvmem-cells and nvmem-cell-names properties are used to supply a
> MAC address to the brcmfmac wireless controller. Nodes such as
> bcm4709-linksys-ea9200.dts fail dtbs_check with:
>
> Unevaluated properties are not allowed ('nvmem-cell-names',
> 'nvmem-cells' were unexpected)
>
> nvmem-consumer.yaml cannot be referenced from the common
> network-class.yaml because it does not constrain the number of entries
> or their names, and not all network devices use the same cell names.
> Each binding that uses nvmem must therefore define its own
> nvmem-cells/nvmem-cell-names constraints, like ethernet-controller.yaml
> and qca,ath9k.yaml already do.
>
> Add the single-cell, mac-address-only constraints to the
> brcm,bcm4329-fmac binding.
>
> Assisted-by: opencode:deepseek-v4-flash-free
Probably for this v2 it is better to say:
Suggested-by: Rob Herring <[email protected]>
> Signed-off-by: Rosen Penev <[email protected]>
> ---
> v2: don't use nvmem-consumer.yaml
> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)