RE: [PATCH] wifi: rtlwifi: remove dead mimo_ps handling from rate update code
Ping-Ke Shih <[email protected]>
| Newsgroups | org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
Chelsy Ratnawat <[email protected]> wrote: > From: Chelsy Ratnawat <[email protected]> > > Several rtlwifi drivers declare mimo_ps as IEEE80211_SMPS_OFF > and never modify it. As a result, conditionals checking for > IEEE80211_SMPS_STATIC or IEEE80211_SMPS_DYNAMIC are false, > making those branches unreachable. > > Remove the unused mimo_ps variables, drop the dead SMPS > branches, and simplify the remaining rate mask selection logic > without changing runtime behavior. Also move ratr_mask > declarations out of the removed conditional blocks where > appropriate. > > Signed-off-by: Chelsy Ratnawat <[email protected]> Acked-by: Ping-Ke Shih <[email protected]> By the way, I think this is v2, right? You should mention this in subject and add change log here with '---' delimiter. But no need resend because of this.