Re: [PATCH v5 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.linux-wireless,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <20260819-generous-nickel-dalmatian-b6bb08@quoll> |
On Tue, Aug 18, 2026 at 12:54:26AM +0300, Georgi Valkov wrote: > > diff --git a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml > index 930b700b73d0..5f235cb9f3e5 100644 > --- a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml > @@ -59,6 +59,12 @@ properties: > description: Calibration data for sub-band 3 in the 5GHz band. > maxItems: 502 > > + marvell,ignore-regulatory-hint: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Ignore an incorrect regulatory hint from ROM, > + so userspace can set the correct regulatory domain. > + Same comments, so you just ignored entire feedback? Again: you need to describe the hardware, in commit msg, in property name and in description. You cannot tell SW what to do, that's not the purpose of bindings. Best regards, Krzysztof