Re: [PATCH wireless-next v3 5/8] wifi: cfg80211: add attribute for TX/RX denoting there is no station

On 8/19/2026 6:57 AM, Benjamin Berg wrote:
> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 020387d76412..4653f8f26ee7 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -3185,6 +3185,11 @@ enum nl80211_commands {
>   *	The aggregated message always precedes the per-link messages for the
>   *	same station within a dump sequence.
>   *
> + * @NL80211_ATTR_FRAME_CMD_NO_STA: Valid for NL80211_CMD_FRAME to denote that

**Minor style concern:** The nl80211.h kdoc comment is at line 3188 but is
missing `@` cross-references to the commands that actually use it
(`NL80211_CMD_FRAME`). Standard nl80211 practice is to reference the specific
command and operation (TX vs RX) more explicitly.

> + *	the kernel had no station for a received frame or should not use a
> + *	known station to transmit a frame. This is relevant to know whether
> + *	MLD address translation happened or to disable it when sending a frame.
> + *
>   * @NUM_NL80211_ATTR: total number of nl80211_attrs available
>   * @NL80211_ATTR_MAX: highest attribute number currently defined
>   * @__NL80211_ATTR_AFTER_LAST: internal use
> @@ -3785,6 +3790,8 @@ enum nl80211_attrs {
>  
>  	NL80211_ATTR_STA_DUMP_LINK_STATS,
>  
> +	NL80211_ATTR_FRAME_CMD_NO_STA,

**NL80211_ATTR_FRAME_CMD_NO_STA name:** The "CMD" in the middle is awkward.
It implies this is only relevant to `NL80211_CMD_FRAME`, which is true, but
the naming convention for other per-command attributes (e.g.
`NL80211_ATTR_FRAME`, `NL80211_ATTR_FRAME_MATCH`) omit "CMD". Consider
`NL80211_ATTR_FRAME_NO_STA` for consistency.

> +
>  	/* add attributes here, update the policy in nl80211.c */
>  
>  	__NL80211_ATTR_AFTER_LAST,
from my review agent,
/jeff