Re: [PATCH v1] wifi: mac80211: fix swapped fq_overlimit/fq_overmemory in aqm debugfs

Julius Bairaktaris <[email protected]> writes:

> The aqm file prints fq_overlimit with fq->overmemory and fq_overmemory
> with fq->overlimit. The fq_overmemory line was added to the format string
> after fq_overlimit while its argument went in before it, and the two have
> been crossed since.
>
> The counters are not interchangeable: fq_tin_enqueue() bumps fq->overlimit
> for every packet the eviction loop drops, and fq->overmemory only for the
> subset dropped because the memory limit was exceeded, so overmemory is
> always the smaller of the two. Reading the file to tell which limit is
> binding gives the opposite answer.
>
> Fixes: 2a4e675d887b ("mac80211: Export fq memory limit information in debugfs")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Julius Bairaktaris <[email protected]>

Reviewed-by: Toke Høiland-Jørgensen <[email protected]>