RE: [PATCH v7 4/6] wifi: rtw88: sdio: track free TX pages and OQT credits for RTL8723BS

On August 25, 2026 10:38:15 AM GMT+02:00, Ping-Ke Shih <[email protected]> wrote:

> Let's review it by v8. Please help to mention this by change log.

Will do, the v8 change log for this patch will say that the transfer moved
into rtw_sdio_write_to_port() and where the alignment warning ended up.

> Okay.

Thanks, I will leave it at warn then.

On your other mail about the back and forth in patch 6: you are right, and
pci.c is the better model. It takes irq_lock around the check and the stop
in rtw_pci_tx_write(), and the wake side runs in rtw_pci_tx_isr() with the
same lock already held by the caller, so the two cannot interleave. That is
why there is no smp_mb, no READ_ONCE and no undo anywhere in pci.c.

I will do the same for SDIO, using the tx_queue spinlock that
skb_queue_tail() and skb_dequeue() already take, and drop the barriers,
the _ONCE accessors and the re-check entirely. That really does change the
locking, so it needs retesting on hardware and v8 will follow once that is
done.

> By the way, I'm not so familiar with SDIO code. Just learn by reviewing. :)

It is working well enough, you have found real bugs in it.

Best regards,
Luka Gejak