Re: [PATCH v8 0/6] wifi: rtw88: preparations for RTL8723B/RTL8723BS

On August 25, 2026 6:33:08 PM GMT+02:00, [email protected] wrote:
>From: Luka Gejak <[email protected]>
>
>This is the first of two series adding support for the Realtek RTL8723B
>802.11n chipset and its RTL8723BS SDIO variant to rtw88. It contains
>only the changes to the shared rtw88 core that the chip driver depends
>on. The chip itself, the build glue and the MAINTAINERS entry are a
>second series.
>

...

Hi Ping-Ke,

A tester has been running v8 on a slow ARM SDIO board. In a good signal
environment it passes a thousand iterations of his stress test with
nothing in the log. In a poor one he still gets "failed to get tx report
from firmware", and a reconnection along with it. Power save was off for
both.

Looking at why, the two ends of the tx report path are not symmetric:

  rtw_tx_report_handle() -> rtw_tx_report_tx_status()
                         -> ieee80211_tx_status_irqsafe()

  rtw_tx_report_purge_timer() -> skb_queue_purge()

When the report arrives mac80211 gets a verdict. When it does not, the
frames are freed with kfree_skb() and mac80211 is told nothing at all.
rtw_tx_report_enqueue() also re-arms the timer on every frame, so it
fires once, 500 ms after the last enqueue, and purges everything
outstanding, including frames queued a moment earlier.

One of the frames that asks for a report is the nullfunc mac80211 sends
to poll a link it suspects is dead. If no status comes back,
ieee80211_sta_tx_notify() is never called, the poll counts as
unanswered, and mac80211 tears the connection down. That fits what the
tester sees: the warning and the reconnection arriving together, and
only when the signal is poor enough for reports to go missing.

Raising the timeout further does not look like the answer. Patch 3 of
this series already takes it to 2500 ms for the RTL8723BS, five times
the default, and he still reaches it. A longer wait only delays the
status.

What looks right to me is to report the frames instead of dropping
them: walk the queue on timeout and hand each one back with
rtw_tx_report_tx_status(rtwdev, cur, false). That tells mac80211 the
frame was not acknowledged, which is true, and lets it act rather than
wait for a status that will never come. It would also stop mac80211 TX
skbs being freed with kfree_skb() instead of being returned through
ieee80211_tx_status().

That is core behaviour for every chip, not just this one, so I would
rather ask than send it. Would you want it as a separate patch outside
this series? And is reporting "not acked" what you would want on the
other parts, or would you rather the timeout stayed silent for them and
only this chip changed?

Best regards,
Luka Gejak