Re: [PATCH net-next v9 03/11] net: Use link netns in newlink() of rtnl_link_ops
Kuniyuki Iwashima <[email protected]>
| Newsgroups | org.kernel.vger.linux-wpan,com.zx2c4.lists.wireguard,dev.linux.lists.bridge,org.kernel.vger.bpf,org.kernel.vger.linux-can,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-ppp,org.kernel.vger.linux-rdma,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.open-mesh.lists.batman |
|---|---|
| Message-ID | <[email protected]> |
From: Xiao Liang <[email protected]> Date: Mon, 10 Feb 2025 21:29:54 +0800 > These netdevice drivers already uses netns parameter in newlink() > callback. Convert them to use rtnl_newlink_link_net() or > rtnl_newlink_peer_net() for clarity and deprecate params->net. > > Signed-off-by: Xiao Liang <[email protected]> Reviewed-by: Kuniyuki Iwashima <[email protected]> > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c > index 8151e91395e2..ab7e5b6649b2 100644 > --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c > +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c > @@ -122,8 +122,8 @@ static int rmnet_newlink(struct net_device *dev, > struct netlink_ext_ack *extack) > { > u32 data_format = RMNET_FLAGS_INGRESS_DEAGGREGATION; > + struct net *link_net = rtnl_newlink_link_net(params); nit: reverse xmas tree > struct nlattr **data = params->data; > - struct net *src_net = params->net; > struct nlattr **tb = params->tb; > struct net_device *real_dev; > int mode = RMNET_EPMODE_VND;