Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

Krzysztof Kozlowski <[email protected]> Wed, 5 Mar 2025 08:04:17 +0100

Newsgroups	org.kernel.vger.linux-wpan,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID	<20250305-rebel-mysterious-falcon-de1f7d@krzk-bin>

On Tue, Mar 04, 2025 at 01:22:34PM +0200, Andy Shevchenko wrote:
> This updates the driver to gpiod API, and removes yet another use of
> of_get_named_gpio().
> 
> With this, invert the logic of the reset pin which is active low
> and add a quirk for the legacy and incorrect device tree descriptions.
> 
> Reviewed-by: Linus Walleij <[email protected]>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
>  .../bindings/net/ieee802154/ca8210.txt        |  2 +-

Bindings are always separate patches.

Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also 'scripts/checkpatch.pl --strict' and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.

Best regards,
Krzysztof