Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

Andy Shevchenko <[email protected]> Wed, 5 Mar 2025 12:47:15 +0200

Newsgroups	org.kernel.vger.linux-wpan,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Message-ID	<[email protected]>

On Wed, Mar 05, 2025 at 08:04:17AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 04, 2025 at 01:22:34PM +0200, Andy Shevchenko wrote:
> > This updates the driver to gpiod API, and removes yet another use of
> > of_get_named_gpio().
> > 
> > With this, invert the logic of the reset pin which is active low
> > and add a quirk for the legacy and incorrect device tree descriptions.
> > 
> > Reviewed-by: Linus Walleij <[email protected]>
> > Signed-off-by: Andy Shevchenko <[email protected]>
> > ---
> >  .../bindings/net/ieee802154/ca8210.txt        |  2 +-
> 
> Bindings are always separate patches.

Okay.

> Please run scripts/checkpatch.pl and fix reported warnings.
> After that,
> run also 'scripts/checkpatch.pl --strict' and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in touch
> if the warning is not clear.

-- 
With Best Regards,
Andy Shevchenko