Re: [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns()

Kuniyuki Iwashima <[email protected]> Thu, 27 Mar 2025 19:30:02 -0700

Newsgroups	org.kernel.vger.linux-wpan,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID	<[email protected]>

From: Ivan Abramov <[email protected]>
Date: Fri, 28 Mar 2025 04:04:26 +0300
> It's pointless to call WARN_ON() in case of an allocation failure in
> dev_change_net_namespace() and device_rename(), since it only leads to
> useless splats caused by deliberate fault injections, so avoid it.
> 
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
> 
> Fixes: 66e5c2672cd1 ("ieee802154: add netns support")
> Suggested-by: Kuniyuki Iwashima <[email protected]>

I suggested using net_warn_ratelimited() so this tag is not needed.
The patch itself looks good to me:

Reviewed-by: Kuniyuki Iwashima <[email protected]>


> Signed-off-by: Ivan Abramov <[email protected]>

Reported-by: [email protected]
Closes: https://lore.kernel.org/netdev/[email protected]/#t