Re: [PATCH] mac802154_hwsim: allow users to specify the number of simulated radios dynamically instead of the previously hardcoded value of 2

Hi,

On Tue, Jun 10, 2025 at 6:54 AM Ramon Fontes <[email protected]> wrote:
>
> Add a module parameter radios to allow users to configure the number
> of virtual radios created by mac802154_hwsim at module load time.
> This replaces the previously hardcoded value of 2.
>
> * Added a new module parameter radios
> * Modified the loop in hwsim_probe()
> * Updated log message in hwsim_probe()
>
> Signed-off-by: Ramon Fontes <[email protected]>
> ---
>  drivers/net/ieee802154/mac802154_hwsim.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index 1cab20b5a..bf6554669 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -27,6 +27,10 @@
>  MODULE_DESCRIPTION("Software simulator of IEEE 802.15.4 radio(s) for mac802154");
>  MODULE_LICENSE("GPL");
>
> +static unsigned int radios = 2;
> +module_param(radios, int, 0444);

this needs to be uint, and I think you had that in the last versions
as I said in the last version.

Sorry but letting that through there will be the next bot detecting
this and somebody else fixing it and I kind of was aware of it.
(Now I have some half of an idea to maybe get rid of that parameter).

- Alex