Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug
Simon Horman <[email protected]> Fri, 4 Jul 2025 15:19:04 +0100
| Newsgroups | org.kernel.vger.linux-wpan,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote:
> ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation
> phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to
> net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited.
>
> Suggested-by: Ido Schimmel <[email protected]>
> Signed-off-by: Wang Liang <[email protected]>
> ---
> Changes in v2:
> Use dynamic debug instead of sysctl.
Thanks, I agree this addresses Ido's review of v1.
And, moreover, is a good approach the problem at hand.