Re: [PATCH net-next v2 3/7] ieee802154: convert dgram getsockopt to sockopt_t
Joe Damato <[email protected]> Wed, 22 Jul 2026 06:40:34 -0700
| Newsgroups | org.kernel.vger.linux-wpan,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.netdev |
|---|---|
| Message-ID | <amDIUv4Sa/[email protected]> |
On Mon, Jul 20, 2026 at 09:17:44AM -0700, Breno Leitao wrote: > Continue converting the proto-layer getsockopt callbacks to the sockopt_t > interface, splitting dgram_getsockopt() into a do_dgram_getsockopt() helper > that takes a sockopt_t. > > No functional change. > > Signed-off-by: Breno Leitao <[email protected]> > --- > net/ieee802154/socket.c | 38 ++++++++++++++++++++++++++------------ > 1 file changed, 26 insertions(+), 12 deletions(-) > > diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c > index 85dce296d7513..763f63e48afe4 100644 > --- a/net/ieee802154/socket.c > +++ b/net/ieee802154/socket.c > @@ -831,20 +831,12 @@ static int ieee802154_dgram_deliver(struct net_device *dev, struct sk_buff *skb) > return ret; > } > > -static int dgram_getsockopt(struct sock *sk, int level, int optname, > - char __user *optval, int __user *optlen) > +static int do_dgram_getsockopt(struct sock *sk, int optname, sockopt_t *opt) > { > struct dgram_sock *ro = dgram_sk(sk); > - > int val, len; > > - if (level != SOL_IEEE802154) > - return -EOPNOTSUPP; > - > - if (get_user(len, optlen)) > - return -EFAULT; > - > - len = min_t(unsigned int, len, sizeof(int)); > + len = min_t(unsigned int, opt->optlen, sizeof(int)); Does the same min() feedback David gave on the last revision apply here as well?