Re: [PATCH v4 1/8] net: Remove the now superfluous sentinel elements from ctl_table array

On Thu, Apr 25, 2024 at 03:58:04PM -0700, Jakub Kicinski wrote:
> On Thu, 25 Apr 2024 14:02:59 +0200 Joel Granados via B4 Relay wrote:
> > -	for (i = 0; i < ARRAY_SIZE(mpls_table) - 1; i++)
> > +	for (i = 0; i < tabel_size; i++)
> >  		table[i].data = (char *)net + (uintptr_t)table[i].data;
> >  
> >  	net->mpls.ctl = register_net_sysctl_sz(net, "net/mpls", table,
> > -					       ARRAY_SIZE(mpls_table));
> > +					       tabel_size);
> 
> ../net/mpls/af_mpls.c: In function ‘mpls_net_init’:
> ../net/mpls/af_mpls.c:2676:25: error: ‘tabel_size’ undeclared (first use in this function); did you mean ‘table_size’?
>  2676 |         for (i = 0; i < tabel_size; i++)
>       |                         ^~~~~~~~~~
>       |                         table_size
> ../net/mpls/af_mpls.c:2676:25: note: each undeclared identifier is reported only once for each function it appears in
> ../net/mpls/af_mpls.c:2660:16: warning: unused variable ‘table_size’ [-Wunused-variable]
>  2660 |         size_t table_size = ARRAY_SIZE(mpls_table);
Sorry about this. I pulled the trigger way too early. This is already
fixed in my v4.
>       |                ^~~~~~~~~~
> -- 
> netdev FAQ tl;dr:
>  - designate your patch to a tree - [PATCH net] or [PATCH net-next]
>  - for fixes the Fixes: tag is required, regardless of the tree
>  - don't post large series (> 15 patches), break them up
>  - don't repost your patches within one 24h period
> 
> pw-bot: cr

-- 

Joel Granados

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYrUNMACgkQupfNUreW
QU8Lzgv/TJmurVNSgO2iDBVQ8bKTLVZCDWpkqOISTJcAhPeC7GVAN0DUGnndUsYY
VWlk378kGRgh4o4vkVoT+vDFGcLfekyBZ7A7+1Hch+Ej8pBi3ehx+O6lrTIvfSLP
WLzkYqO7D1w7m8im/Bxj5D3i3d1oGVY4SYptq2ZFMzwecJMwEVxKTd12FPvaKDWj
3dIO/lGPDyMckpa1NNjioclQH/3bjchV7EN9vMgX9tq031kCW6IHzijIecYxoxC1
03w84MltO003waD5EsSw7/V14Db62XqxmYwMXzIv4MLe0prEc7s18scPpP9nJOpF
1oHVmtXm/iz9O1E6r+cuiGGZTNMF8NOF7XfmgosExm43utnVXCzjouGOn5FbFd8O
hZ6YkOLlQaNXi6B8TveTe0PKN8h0TzKporAIjD6vuKpaSRrM2i74Mo7870R6STD5
niiT2phZNFuC2ezKpGVCgY67f87SnHLmu1uXbDdoI7aVATzEWUNwDp6V7DHP0vB5
+KgDXCQs
=+u1k
-----END PGP SIGNATURE-----