Re: [PATCH net-next v6 8/8] ax.25: x.25: Remove the now superfluous sentinel elements from ctl_table array
Dan Carpenter <[email protected]>
| Newsgroups | org.kernel.vger.linux-x25,dev.linux.lists.bridge,dev.linux.lists.mptcp,org.kernel.vger.dccp,org.kernel.vger.linux-hams,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-rdma,org.kernel.vger.linux-s390,org.kernel.vger.linux-sctp,org.kernel.vger.linux-wpan,org.kernel.vger.lvs-devel,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, May 03, 2024 at 02:18:11PM +0200, Joel Granados wrote: > On Wed, May 01, 2024 at 03:15:54PM +0200, Sabrina Dubroca wrote: > > 2024-05-01, 11:29:32 +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados <[email protected]> > > > diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c > > > index c4f8adbf8144..c50a58d9e368 100644 > > > --- a/net/ax25/ax25_ds_timer.c > > > +++ b/net/ax25/ax25_ds_timer.c > > > @@ -55,6 +55,7 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev) > > > ax25_dev->dama.slave_timeout = > > > msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10; > > > mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ); > > > + return; > > > > nit: return not needed here since we're already at the bottom of the > > function, but probably not worth a repost of the series. > > > Thx. I will not repost, but I have changed them locally so they are > there in case a V7 is required. > It's a checkpatch.pl -f warning so we probably will want to fix it eventually. regards, dan carpenter