Re: [PATCH v2 net] net: lapbether: handle NETDEV_PRE_TYPE_CHANGE
Simon Horman <[email protected]> Fri, 3 Apr 2026 16:55:28 +0100
| Newsgroups | org.kernel.vger.linux-x25,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Apr 02, 2026 at 10:35:19AM +0000, Eric Dumazet wrote:
> lapbeth_data_transmit() expects the underlying device type
> to be ARPHRD_ETHER.
>
> Returning NOTIFY_BAD from lapbeth_device_event() makes sure
> bonding driver can not break this expectation.
>
> Fixes: 872254dd6b1f ("net/bonding: Enable bonding to enslave non ARPHRD_ETHER")
> Reported-by: [email protected]
> Closes: https://lore.kernel.org/netdev/[email protected]/T/#u
> Signed-off-by: Eric Dumazet <[email protected]>
> Cc: Martin Schiller <[email protected]>
> Cc: [email protected]
> ---
> v2: cache lapbeth_get_x25_dev() result in @lapbeth.
> make sure @lapbeth is set before returning NOTIFY_BAD.
Reviewed-by: Simon Horman <[email protected]>