Re: [PATCH 5/6] xfs: write the rg superblock when fixing it
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 13, 2026 at 02:58:57PM -0700, Darrick J. Wong wrote: > Hrmm. Right now both superblock scrubbers don't do much for group 0, > because both buffers are pinned to the xfs_mount, so they assume that > there's no need to check anything. However, the ondisk super could have > gotten corrupted (or blown away by fdisk), in which case an immediate > crash could render the filesystem unmountable. > > So, I could (a) teach the super scrubbers to read the primary / rt > super; and (b) teach them both to log the superblock and bwrite it > immediately to shorten the window in which this could happen. > > What do you think? I guess the only sensible time to scrub the sb would be early during mount? > Also, this patch should be calling xfs_log_sb *after* xfs_trans_getsb, > so I'll fix that for the repost. Oops.