Re: [PATCH 3/6] xfs: handle non-inode owners for rtrmap record checking

On Tue, Jul 14, 2026 at 08:14:09AM +0200, Christoph Hellwig wrote:
> On Mon, Jul 13, 2026 at 11:06:43PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <[email protected]>
> > 
> > LOLLM noticed that two helper functions in the rtrmapbt scrub code don't
> > actually handle non-inode owners correctly -- CoW staging extents and
> > rgsuperblock extents are not shareable, but they are mergeable.  Fix
> > these two helpers.
> 
> The changes looks reasonable:
> 
> Reviewed-by: Christoph Hellwig <[email protected]>
> 
> But why do we consider RT superblocks mergable?

We don't, really, but most of the cross-referencing code in the two
repair tools don't look at the adjacent records just in case someone
split a record wrongly.  Except for the bmap btree, the kernel never
splits mergeable records which is why it's an error in the rmap btree.

--D