Re: [PATCH 1/6] xfs: set xfarray killable sort correctly
"Darrick J. Wong" <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.stable |
|---|---|
| Message-ID | <20260714164209.GF7398@frogsfrogsfrogs> |
On Tue, Jul 14, 2026 at 08:11:34AM +0200, Christoph Hellwig wrote: > On Mon, Jul 13, 2026 at 11:06:12PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <[email protected]> > > > > LOLLM noticed that we *disable* interruptible sorts when the KILLABLE > > flag is set. This is backwards. Fix the incorrect logic, and rename > > the variable to make the connection more obvious. > > Looks good: > > Reviewed-by: Christoph Hellwig <[email protected]> > > Can we come up with a test that actually kills a sort somewhat reliably? Userspace doesn't have good visibility into when a sort is running, and I don't think we want to add XFS_TEST_ERROR() chunks where we inject a SIGKILL into current... however that might be done. --D