Re: [PATCH v2 02/18] xfs: convert iomap ops to ->iomap_next()

On Mon, Jul 20, 2026 at 1:20 AM Christoph Hellwig <[email protected]> wrote:
>
> > static int
> > xfs_seek_iomap_next(
> >        const struct iomap_iter *iter,
> >        struct iomap            *iomap,
> >        struct iomap            *srcmap)
> > {
> >        return iomap_iter_next(iter, iomap, srcmap, xfs_seek_iomap_begin, NULL);
> > }
>
> Looks fine.  And this might also be on of the rare case where a littl macro
> magic to generate this might fine.  I.e. turn this into:
>
> static DEFINE_IOMAP_ITER_NEXT(xfs_read_iomap_next, xfs_seek_iomap_begin);
> static DEFINE_IOMAP_ITER_NEXT(xfs_seek_iomap_next, xfs_read_iomap_begin);
>
> and
>
> static DEFINE_IOMAP_ITER_NEXT_END(xfs_buffered_write_iomap_next,
>                 xfs_buffered_write_iomap_begin, xfs_buffered_write_iomap_end);
>
> (could be shorted with string concatenations, but those are really annoying..)
>

Sounds good, I'll add this to v3.

Thanks,
Joanne