Re: [PATCH v2 0/4] xfs: consolidate metadir creation code
Carlos Maiolino <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <178463068379.324722.6480297471571446611.b4-ty@b4> |
On Mon, 13 Jul 2026 14:42:46 +0200, Johannes Thumshirn wrote:
> The XFS metadata directory tree has grown several nearly identical
> open-coded copies of the "create a metadata inode" sequence: allocate the
> creation transaction, create and link the inode, do a bit of type
> specific inode setup, commit, and finish or tear down the inode on both
> the success and error paths.
>
> Factor that boilerplate into a single helper, xfs_metadir_create_file(),
> which takes the file mode and an optional callback to finish initializing
> the new inode inside the creation transaction, and convert the existing
> users - xfs_metadir_mkdir(), the quota inodes and the rtgroup inodes -
> over to it.
>
> [...]
Applied to for-next, thanks!
[1/4] xfs: add xfs_metadir_create_file helper
commit: 9bb976117a1b81504af4389a849d1af5938d7142
[2/4] xfs: create quota metadir inodes using xfs_metadir_create_file
commit: 6b0b126b05cd50587d77d5b7cf893170719adbe5
[3/4] xfs: create rtgroup metadir inodes using xfs_metadir_create_file
commit: 4885de0d9a15db65545a7b1cf632797302cfcf3a
[4/4] xfs: mark internal metadir file creation helpers static
commit: eaef2d68a491dcde0c20cac31f54f2b961909bd7
Best regards,
--
Carlos Maiolino <[email protected]>