Re: improve log context annotations
"Darrick J. Wong" <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <20260721152348.GY7380@frogsfrogsfrogs> |
On Tue, Jul 21, 2026 at 05:01:42PM +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2026 at 11:16:40AM +0200, Carlos Maiolino wrote: > > Thanks. Those all look good for me. But I'm adding Dave to the thread as > > he has much more expertise with lockdep than me and I'd appreciate his > > input. > > More review is always good. But as a reminder for the audience: > lockdep and the lock context annotations are two totally seaprate > things. The former verifies the locking state at runtime, while > the latter is about compile-time enforcement for the cases where > that is possible. <shrug> The new annotations are consistent with my understanding of the annotated functions, but as I don't build with clang I can't say I've actually dug into its auto-verifier features, let alone run it. --D