Re: [PATCH 5/9] xfs: pass runtime errors from xrep_iunlink_mark_ondisk_rec up to callers

Christoph Hellwig <[email protected]>
Newsgroups org.kernel.vger.linux-xfs,org.kernel.vger.stable
Message-ID <[email protected]>
On Mon, Jul 20, 2026 at 08:26:06PM -0700, Darrick J. Wong wrote:
> +	/*
> +	 * Don't proceed if we couldn't set a bit in the bitmap.  All other
> +	 * errors we ignore because we haven't actually checked the inobt yet.
> +	 */
> +	if (error == -ENOMEM)
> +		return -ENOMEM;
> +	return 0;

To me this would feel a bit more natural as

	if (error != -ENOMEM)
		return 0;
	return error;

but either way will work perfectly fine.

Reviewed-by: Christoph Hellwig <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.