Re: [PATCH 20/22] xfs: add support for lazy direct read bounce buffering

On Thu, Jul 23, 2026 at 02:05:50PM -0700, Darrick J. Wong wrote:
> > +			 * We only really need to retry for guard tag errors,
> > +			 * but right now we can't distinguish them from other
> > +			 * (i.e, reftag) errors.
> > +			 */
> > +			if (error) {
> > +				xfs_read_bounce_and_resubmit(ioend);
> 
> Ahah, yes we are being mean and making userspace wait for a slow bounce
> buffer workaround if they mess with us.

Yes.

> > +	/* .../xfs/<dev>/csum/ */
> > +	error = xfs_sysfs_init(&mp->m_csum_kobj, &xfs_csum_ktype,
> > +			       &mp->m_kobj, "csum");
> > +	if (error)
> > +		goto out_remove_error_dir;
> 
> /me wonders if this is a debugging knob and therefore should go in
> debugfs?  Or is there a solid usecase for normal sysadmins to be able to
> control this?

I consider it an insurance again mispredicting user workloads.  debugfs
also is really painful in general, and especially for trivial files
likes this where it requires tons of boilerplate for no reason.