Re: [PATCH 20/22] xfs: add support for lazy direct read bounce buffering

On Fri, Jul 24, 2026 at 08:24:43AM +0200, Christoph Hellwig wrote:
> > > +	/* .../xfs/<dev>/csum/ */
> > > +	error = xfs_sysfs_init(&mp->m_csum_kobj, &xfs_csum_ktype,
> > > +			       &mp->m_kobj, "csum");
> > > +	if (error)
> > > +		goto out_remove_error_dir;
> > 
> > /me wonders if this is a debugging knob and therefore should go in
> > debugfs?  Or is there a solid usecase for normal sysadmins to be able to
> > control this?
> 
> I consider it an insurance again mispredicting user workloads.  debugfs
> also is really painful in general, and especially for trivial files
> likes this where it requires tons of boilerplate for no reason.

Also: I'm not particular happy about the placement of this file
in sysfs.  Do we want a misc group, or rw?  The current one feels
a bit too specific, which means we'd keep on growing way too many
groups in the future.