Re: [PATCH 08/12] xfs: don't reverify buffers in xfs_buf_readahead_map

On Wed, Jul 15, 2026 at 04:51:01PM +0200, Christoph Hellwig wrote:
> xfs_buf_read_map calls xfs_buf_reverify to ensure the verifier has run
> for a buffer before the data can be used when an earlier readahead read
> the data before the buf_ops were assigned.
> 
> There is no point in doing this in xfs_buf_readahead_map for a buffer
> already in memory as a later xfs_buf_read will do the same and can
> actually propagate the error to the caller.
> 
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
>  fs/xfs/xfs_buf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 2a0a19172847..4430da3259f1 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -760,7 +760,6 @@ xfs_buf_readahead_map(
>  	trace_xfs_buf_readahead(bp, 0, _RET_IP_);
>  
>  	if (bp->b_flags & XBF_DONE) {
> -		xfs_buf_reverify(bp, ops);

Agreed, there's no point in tripping the verifiers and logging a bunch
of complaints twice.

Reviewed-by: "Darrick J. Wong" <[email protected]>

--D

>  		xfs_buf_relse(bp);
>  		return;
>  	}
> -- 
> 2.53.0
> 
>