Re: [PATCH 4/6] xfs: don't zap the attr fork on repair when there are queued pptr updates
"Darrick J. Wong" <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.stable |
|---|---|
| Message-ID | <20260724170523.GA2901224@frogsfrogsfrogs> |
On Fri, Jul 24, 2026 at 03:25:26PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 23, 2026 at 11:22:03PM -0700, Darrick J. Wong wrote:
> > - if (rx->attrs_found == 0) {
> > + if (rx->attrs_found == 0 && (!xfs_has_parent(sc->mp) ||
> > + xfarray_length(rx->pptr_recs) == 0)) {
>
> Hmm, this formatting looks at least a bit confusing. Why not:
>
> if (rx->attrs_found == 0 &&
> (!xfs_has_parent(sc->mp) || xfarray_length(rx->pptr_recs) == 0)) {
>
> ?
Yeah, I will fix this.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <[email protected]>
Thanks for reviewing this series!
--D