Re: [PATCH 1/2] xfs: fix ilock leak on error in xfs_dq_get_next_id

Christoph Hellwig <[email protected]> Mon, 27 Jul 2026 20:17:12 -0700

Newsgroups	org.kernel.vger.linux-xfs
Message-ID	<[email protected]>

On Mon, Jul 27, 2026 at 10:38:48AM +0800, Long Li wrote:
> xfs_dq_get_next_id() takes the quota inode ILOCK before calling
> xfs_iread_extents().  If xfs_iread_extents() fails, the function returns
> immediately without releasing the lock, leaking the quota inode ILOCK.
> This can leave the quota inode locked and cause subsequent quota
> operations to hang.
> 
> Fix this by jumping to a common unlock path on error instead of returning
> directly.

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>