Re: [PATCH 2/2] iomap: iomap_bio_read_folio_range_sync is missing a call to bio_uninit
"Darrick J. Wong" <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <20260804174609.GG3556460@frogsfrogsfrogs> |
On Tue, Aug 04, 2026 at 05:43:58AM -0700, Christoph Hellwig wrote:
> Which could leak blkg references.
>
> Fixes: c03cea42149d ("iomap: add initial support for writes without buffer heads")
> Signed-off-by: Christoph Hellwig <[email protected]>
Makes sense that we have to uninit that which we initted earlier;
Reviewed-by: "Darrick J. Wong" <[email protected]>
--D
> ---
> fs/iomap/bio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/iomap/bio.c b/fs/iomap/bio.c
> index 30ef78a66b4f..48100c614431 100644
> --- a/fs/iomap/bio.c
> +++ b/fs/iomap/bio.c
> @@ -184,5 +184,6 @@ int iomap_bio_read_folio_range_sync(const struct iomap_iter *iter,
> error = fs_bio_integrity_verify(&bio, sector, len);
> fs_bio_integrity_free(&bio);
> }
> + bio_uninit(&bio);
> return error;
> }
> --
> 2.53.0
>
>