Re: [PATCH] xfs: fix IOMAP_F_DIRTY flag overwrite in zoned DIO
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 10, 2026 at 05:21:31PM +0200, Andrey Albershteyn wrote:
> Missing IOMAP_F_DIRTY prevents completion handlers from updating i_size
> on the direct IO path, the flag is set but was overwritten by
> IOMAP_F_ANON_WRITE latter. The writeback path for buffered IO doesn't
> seem to require IOMAP_F_DIRTY and looks like an error.
>
> Fixes: 2e2383405824 ("xfs: implement direct writes to zoned RT devices")
> Signed-off-by: Andrey Albershteyn <[email protected]>
I actually have exactly the same fix in a series I'm about to send
out, and a cleanup to move this into common code.
I guess we both saw the same Sashiko comment :)