Re: [PATCH 3/5] xfs: fix zoned write iomap flags assignments
Andrey Albershteyn <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-10 08:37:44, Christoph Hellwig wrote:
> Don't overwrite IOMAP_F_DIRTY with IOMAP_F_ANON_WRITE, but ensure both
> flags are set instead.
>
> Note that in practice this is harmless as all zoned writes force a metadata
> transaction anyway, but incorrectly assigned flags are still a landmine
> that will cause problems at some point.
>
> Fixes: 058dd70c65ab ("xfs: implement buffered writes to zoned RT devices")
> Fixes: 2e2383405824 ("xfs: implement direct writes to zoned RT devices")
> Signed-off-by: Christoph Hellwig <[email protected]>
Looks good to me
Reviewed-by: Andrey Albershteyn <[email protected]>
> ---
> fs/xfs/xfs_aops.c | 3 +--
> fs/xfs/xfs_iomap.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index c80f05507373..9506cd8d15e6 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -634,11 +634,10 @@ xfs_zoned_map_blocks(
> xfs_iunlock(ip, XFS_ILOCK_EXCL);
>
> wpc->iomap.type = IOMAP_MAPPED;
> - wpc->iomap.flags = IOMAP_F_DIRTY;
> wpc->iomap.bdev = mp->m_rtdev_targp->bt_bdev;
> wpc->iomap.offset = offset;
> wpc->iomap.length = XFS_FSB_TO_B(mp, count_fsb);
> - wpc->iomap.flags = IOMAP_F_ANON_WRITE;
> + wpc->iomap.flags = IOMAP_F_ANON_WRITE | IOMAP_F_DIRTY;
Does it make sense to set IOMAP_F_DIRTY here? I haven't found how it
could be used
--
- Andrey