Re: [RFC PATCH v3 09/11] xfs: Implement RWF_NOSERIAL to parallelize RWF_WRITETHROUGH writes

"Pankaj Raghav (Samsung)" <[email protected]>
Newsgroups org.kernel.vger.linux-xfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kvack.linux-mm
Message-ID <aoMMIfyEuuaDFpMh@quentin>
>  	}
>  
> +	/*
> +	 * Writethrough implies non-serial writes ie writes can go
> +	 * parallelly.
> +	 */
> +	if (flags & RWF_WRITETHROUGH)
> +		kiocb_flags |= IOCB_NOSERIAL;
> +

From a user perspective, shouldn't this be an explicit user flag instead
of implicitly enabling for all RWF_WRITETHROUGH?

Power users who would want performance over POSIX compliance can enable
this but it should not be the other way around IMO.

--
Pankaj
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.