Re: [PATCH v4 5/6] xfs: write stream based AG placement

Christoph Hellwig <[email protected]>
Newsgroups org.kernel.vger.linux-xfs,org.kernel.vger.linux-block,org.kernel.vger.linux-fsdevel
Message-ID <[email protected]>
On Fri, Jul 17, 2026 at 06:25:37PM +0530, Kanchan Joshi wrote:
> If AGs are fewer than write streams, write streams are distributed into
> available AGs in round robin fashion.

I think we should just limit the number of available write streams
to the number of AG, as otherwise we'll get into a bit of a mess.

And for the case of the hardware write streams query them in mkfs
to align the AG geometry to that.

> +	uint32_t		nr_streams = xfs_inode_max_write_streams(ip);
> +	uint32_t		stream_id = ip->i_write_stream;
> +	uint32_t		nr_ags = mp->m_sb.sb_agcount;
> +	xfs_agnumber_t		set_size;
> +
> +
> +	if (!nr_streams)

Double empty line.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.