Re: [RFC PATCH v3 09/11] xfs: Implement RWF_NOSERIAL to parallelize RWF_WRITETHROUGH writes
Ojaswin Mujoo <[email protected]>
| Newsgroups | org.kernel.vger.linux-xfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 17, 2026 at 03:33:06PM +0200, Pankaj Raghav (Samsung) wrote: > > } > > > > + /* > > + * Writethrough implies non-serial writes ie writes can go > > + * parallelly. > > + */ > > + if (flags & RWF_WRITETHROUGH) > > + kiocb_flags |= IOCB_NOSERIAL; > > + > > From a user perspective, shouldn't this be an explicit user flag instead > of implicitly enabling for all RWF_WRITETHROUGH? > > Power users who would want performance over POSIX compliance can enable > this but it should not be the other way around IMO. > > -- > Pankaj Hi Pankaj, Yes I think we just wanted to float the idea of such a flag but I was unsure right now whether to have users pass it or enable it implicitly. Thinking about it again I think I agree that we can allow users to pass it even if we just reject it for all cases except writethrough (for now). Regards, ojaswin