Re: [PATCH v2 24/53] klp-build: Fix checksum comparison for changed offsets

Song Liu <[email protected]>
Newsgroups org.kernel.vger.live-patching,org.kernel.vger.linux-kernel
Message-ID <CAPhsuW6fDMrgYAHC+LZmDP+4-u_FaND3cb5U-vtQeM+FpV2XdA@mail.gmail.com> 
On Fri, May 1, 2026 at 5:09 AM Josh Poimboeuf <[email protected]> wrote:
>
> The klp-build -f/--show-first-changed feature uses diff to compare
> checksum log lines between original and patched objects.  However, diff
> compares entire lines, including the offset field.  When a function is
> at a different section offset, the offset field differs even though the
> instruction checksum is identical, causing the wrong instruction to be
> printed.
>
> Only compare the checksum field when looking for the first changed
> instruction.  Also print both the original and patched offsets when they
> differ.
>
> Fixes: 78be9facfb5e ("livepatch/klp-build: Add --show-first-changed option to show function divergence")
> Signed-off-by: Josh Poimboeuf <[email protected]>

Acked-by: Song Liu <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.