Re: [PATCH v2 24/53] klp-build: Fix checksum comparison for changed offsets
Miroslav Benes <[email protected]>
| Newsgroups | org.kernel.vger.live-patching,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <177797554542.9921.15231697922536568953.b4-review@b4> |
On Thu, 30 Apr 2026 21:08:12 -0700, Josh Poimboeuf <[email protected]> wrote: > The klp-build -f/--show-first-changed feature uses diff to compare > checksum log lines between original and patched objects. However, diff > compares entire lines, including the offset field. When a function is > at a different section offset, the offset field differs even though the > instruction checksum is identical, causing the wrong instruction to be > printed. > > [...] Reviewed-by: Miroslav Benes <[email protected]> -- Miroslav