Re: [PATCH v2] selftests/livepatch: fix resource leak in test_klp_syscall init error path
Petr Mladek <[email protected]> Thu, 4 Jun 2026 15:12:07 +0200
| Newsgroups | org.kernel.vger.live-patching,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Message-ID | <[email protected]> |
On Thu 2026-06-04 16:32:08, Rui Qi wrote: > In livepatch_init(), if klp_enable_patch() fails, the previously > created kobject and sysfs file are never cleaned up, causing a > resource leak. Capture the return value and add proper cleanup > on the error path. > > Signed-off-by: Rui Qi <[email protected]> The patch looks good to me. I would ignore the proble reported by Sashiko. so: Reviewed-by: Petr Mladek <[email protected]> Best Regards, Petr PS: I am going to push this patch early next week if nobody complained in the meantime.