[PATCH] selftests: livepatch: filter kobject debug messages in check_result()
Yafang Shao <[email protected]>
| Newsgroups | org.kernel.vger.live-patching |
|---|---|
| Message-ID | <[email protected]> |
CONFIG_DEBUG_KOBJECT makes kobject_add_internal(), kobject_uevent_env(), fill_kobj_path() and friends emit pr_debug() messages, and CONFIG_DEBUG_KOBJECT_RELEASE makes kobject_release() emit a pr_info() for every delayed kobject free. All of these carry the "kobject:" prefix via pr_fmt(), e.g.: kobject: 'test_klp_livepatch' (ffff...): kobject_release, parent ... (delayed N) kobject: 'test_klp_livepatch' (ffff...): kobject_add_internal: parent: 'module', set: 'module' The livepatch test modules' kobjects are named "test_klp_*", so these lines match the check_result() grep for "test_klp" and leak into the result. The extra lines no longer match the expected output, so the selftests fail when either debug config is enabled. Filter out the "kobject:" lines from the result and note in the README that both configs are safe to keep enabled. Signed-off-by: Yafang Shao <[email protected]> --- tools/testing/selftests/livepatch/README | 3 +++ tools/testing/selftests/livepatch/functions.sh | 1 + 2 files changed, 4 insertions(+) diff --git a/tools/testing/selftests/livepatch/README b/tools/testing/selftests/livepatch/README index d2035dd64a2b..d03461bd45bb 100644 --- a/tools/testing/selftests/livepatch/README +++ b/tools/testing/selftests/livepatch/README @@ -15,6 +15,9 @@ Config Set CONFIG_LIVEPATCH=y option and it's prerequisites. +Note: CONFIG_DEBUG_KOBJECT and CONFIG_DEBUG_KOBJECT_RELEASE emit "kobject:" +debug messages to the kernel log. The tests filter these out, so they are safe +to keep enabled. Building the tests ------------------ diff --git a/tools/testing/selftests/livepatch/functions.sh b/tools/testing/selftests/livepatch/functions.sh index 17810521d069..3dae2ad20f1e 100644 --- a/tools/testing/selftests/livepatch/functions.sh +++ b/tools/testing/selftests/livepatch/functions.sh @@ -327,6 +327,7 @@ function check_result { result=$(dmesg | awk -v last_dmesg="$LAST_DMESG" 'p; $0 == last_dmesg { p=1 }' | \ grep -e 'livepatch:' -e 'test_klp' | \ grep -v '\(tainting\|taints\) kernel' | \ + grep -v 'kobject:' | \ sed 's/^\[[ 0-9.]*\] //' | \ sed 's/^\[[ ]*[CT][0-9]*\] //') -- 2.52.0