Re: [PATCH] ipvs: use explicitly signed chars
"Jason A. Donenfeld" <[email protected]>
| Newsgroups | org.kernel.vger.lvs-devel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel,org.kernel.vger.stable |
|---|---|
| Message-ID | <CAHmME9phbAJEbogBVZqmmb+44_V--rG_L5hAZCWeJVJy6-W7ag@mail.gmail.com> |
Hi Pablo, On Wed, Oct 26, 2022 at 2:34 PM Jason A. Donenfeld <[email protected]> wrote: > > The `char` type with no explicit sign is sometimes signed and sometimes > unsigned. This code will break on platforms such as arm, where char is > unsigned. So mark it here as explicitly signed, so that the > todrop_counter decrement and subsequent comparison is correct. > > Cc: Pablo Neira Ayuso <[email protected]> > Cc: Julian Anastasov <[email protected]> > Cc: Simon Horman <[email protected]> > Cc: [email protected] > Signed-off-by: Jason A. Donenfeld <[email protected]> Wondering if you planned on taking this into nf.git for 6.1? Thanks, Jason