Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comment

WangYuli <[email protected]> Tue, 22 Jul 2025 16:05:26 +0800
Newsgroups org.kernel.vger.lvs-devel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel
Message-ID <4DFD87AA0CE5EA72+aebc5df6-9174-4ecf-9dc9-3abb312defc1@uniontech.com>
Hi Pablo Neira Ayuso,

On 2025/7/22 11:25, Pablo Neira Ayuso wrote:
> On Fri, Jul 04, 2025 at 04:35:53PM +0800, WangYuli wrote:
>> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
>> switched del_timer to timer_delete, but did not modify the comment for
>> ip_vs_conn_expire_now(). Now fix it.
> $ git grep del_timer net/netfilter/
> net/netfilter/ipvs/ip_vs_lblc.c: *     Julian Anastasov        :    replaced del_timer call with del_timer_sync
> net/netfilter/ipvs/ip_vs_lblc.c: *                                   handler and del_timer thread in SMP
>
> Wider search, in the net tree:
>
> net/ipv4/igmp.c: *                                      which caused a "del_timer() called
> net/ipv4/igmp.c: *              Christian Daudt :       removed del_timer from
>
> Maybe these are only for historical purpose, so leaving them untouched
> is fine.
>
I intentionally modified only this part, leaving the other places you 
found untouched.

My goal was to update only the comment for this code block, not the 
file's changelog.


Thanks,

-- 
WangYuli
OpenPGP_0xC5DA1F3046F40BEE.asc (application/pgp-keys, 632 B)
-----BEGIN PGP PUBLIC KEY BLOCK-----

xjMEZoEsiBYJKwYBBAHaRw8BAQdAyDPzcbPnchbIhweThfNK1tg1imM+5kgDBJSK
P+nX39DNIVdhbmdZdWxpIDx3YW5neXVsaUB1bmlvbnRlY2guY29tPsKJBBMWCAAx
FiEEa1GMzYeuKPkgqDuvxdofMEb0C+4FAmaBLIgCGwMECwkIBwUVCAkKCwUWAgMB
AAAKCRDF2h8wRvQL7g0UAQCH3mrGM0HzOaARhBeA/Q3AIVfhS010a0MZmPTRGVfP
bwD/SrncJwwPAL4GiLPEC4XssV6FPUAY0rA68eNNI9cJLArOOARmgSyJEgorBgEE
AZdVAQUBAQdA88W4CTLDD9fKwW9PB5yurCNdWNS7VTL0dvPDofBTjFYDAQgHwngE
GBYIACAWIQRrUYzNh64o+SCoO6/F2h8wRvQL7gUCZoEsiQIbDAAKCRDF2h8wRvQL
7sKvAP4mBvm7Zn1OUjFViwkma8IGRGosXAvMUFyOHVcl1RTgFQEAuJkUo9ERi7qS
/hbUdUgtitI89efbY0TVetgDsyeQiwU=
=Blkq
-----END PGP PUBLIC KEY BLOCK-----
OpenPGP_signature.asc (application/pgp-signature, 236 B)
-----BEGIN PGP SIGNATURE-----

wnsEABYIACMWIQRrUYzNh64o+SCoO6/F2h8wRvQL7gUCaH9GRgUDAAAAAAAKCRDF2h8wRvQL7gwh
AQD+b6zSXab3OX8ehDxFFWIDaNEuEcWNgwe8KckxeUJLCwEA/a+pT5OaBoXOrDvuUSxrem7LXlM6
dIjddT3Qgh/H1gg=
=xVG0
-----END PGP SIGNATURE-----