+ mm-ksm-avoid-missing-ksmd-wakeups-in-ksm_enter.patch added to mm-new branch
Andrew Morton <[email protected]> Mon, 03 Aug 2026 11:11:20 -0700
| Newsgroups | org.kernel.vger.mm-commits |
|---|---|
| Message-ID | <[email protected]> |
The patch titled
Subject: mm/ksm: avoid missing ksmd wakeups in ksm_enter
has been added to the -mm mm-new branch. Its filename is
mm-ksm-avoid-missing-ksmd-wakeups-in-ksm_enter.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-ksm-avoid-missing-ksmd-wakeups-in-ksm_enter.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Longlong Xia <[email protected]>
Subject: mm/ksm: avoid missing ksmd wakeups in ksm_enter
Date: Mon, 3 Aug 2026 23:21:15 +0800
__ksm_enter() decides whether ksmd needs a wakeup by checking if the mm
slot list is empty before inserting the new slot.
The empty check is currently outside ksm_mmlist_lock. Another CPU can
remove the last slot and let ksmd go back to sleep after the unlocked
check, while this CPU inserts a new slot and skips the wakeup based on the
stale result.
Take ksm_mmlist_lock before checking the list so the empty-to-nonempty
transition and the insertion are observed as one critical section.
Link: https://lore.kernel.org/[email protected]
Fixes: 6e15838425ac ("ksm: keep quiet while list empty")
Signed-off-by: Longlong Xia <[email protected]>
Cc: Chengming Zhou <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: Izik Eidus <[email protected]>
Cc: Xu Xin <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---
mm/ksm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/mm/ksm.c~mm-ksm-avoid-missing-ksmd-wakeups-in-ksm_enter
+++ a/mm/ksm.c
@@ -3053,7 +3053,7 @@ int __ksm_enter(struct mm_struct *mm)
{
struct ksm_mm_slot *mm_slot;
struct mm_slot *slot;
- int needs_wakeup;
+ bool needs_wakeup;
mm_slot = mm_slot_alloc(mm_slot_cache);
if (!mm_slot)
@@ -3061,10 +3061,9 @@ int __ksm_enter(struct mm_struct *mm)
slot = &mm_slot->slot;
+ spin_lock(&ksm_mmlist_lock);
/* Check ksm_run too? Would need tighter locking */
needs_wakeup = list_empty(&ksm_mm_head.slot.mm_node);
-
- spin_lock(&ksm_mmlist_lock);
mm_slot_insert(mm_slots_hash, mm, slot);
/*
* When KSM_RUN_MERGE (or KSM_RUN_STOP),
_
Patches currently in -mm which might be from [email protected] are
mm-ksm-avoid-missing-ksmd-wakeups-in-ksm_enter.patch