Re: + radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment.patch added to mm-new branch

Breno Leitao <[email protected]>
Newsgroups org.kernel.vger.mm-commits
Message-ID <[email protected]>
On Tue, Aug 11, 2026 at 09:52:42AM +0100, Catalin Marinas wrote:
> On Mon, Aug 10, 2026 at 08:18:14PM -0700, Andrew Morton wrote:
> > On Tue, 7 Jul 2026 04:26:43 -0700 Breno Leitao <[email protected]> wrote:
> >
> > > > Anyway, a better diff for the first idea below. I need to do more
> > > > testing and can turn it into a proper commit (if we don't deem it
> > > > redundant because of the other min_unref_count).
> > >
> > > Thanks for it. I've reviewed it and it looks sane.
> > >
> > > I am also testing it on my side.
> >
> > This went quiet.  I take it that we won't be proceeding with this
> > patch, "radix-tree: fix kmemleak false positives on tree head
> > reassignment", v2?
>
> Yeah, I think the recent heuristics additions make this annotation
> unnecessary. Well, Breno to confirm.

Agreed. I've pulled all the latest kmemleak patches into Meta's kernel
(including this one), and the false positive rate is now much lower
than before (althought I still don't have much bake time).

I'd suggest dropping this one and instead continuing to improve
kmemleak itself to avoid these false positives where possible.

That said, I'll let Meta's kernel bake a bit longer, and if more false
positives turn up I'll report back so we can decide how to proceed.

Thanks,
--breno
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.