Re: [PATCH net-next 2/2] net: stmmac: ethtool: Address off-by-one when reading the coal rx-usecs
Andrew Lunn <[email protected]>
| Newsgroups | org.kernel.vger.netdev,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Aug 02, 2026 at 10:29:22PM +0200, Maxime Chevallier wrote: > Hi Andrew, > > On 8/2/26 17:05, Andrew Lunn wrote: > >> This does change the boundaries of accepted rx-usecs parameters, as the > >> previously accepted values were in the 16-246 us range, and now fall > >> into the 15-245 range on imx8mp. > > > > With this change in place, what happens when trying to set 246? > > EINVAL? > > Yes indeed : > > # ethtool -C eth1 rx-usecs 246 > netlink error: Invalid argument I guess nobody will report a regression, but if they do, we can map 246 to 245. But until somebody does report it: Reviewed-by: Andrew Lunn <[email protected]> Andrew