[PATCH net-next v2 2/3] net: stmmac: fpe: Add missing return in stmmac_fpe_init()
| Newsgroups | org.kernel.vger.netdev,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260803032358.16282-3-muhammad.nazim.amirul.nazle.asmade@altera.com> |
From: Nazim Amirul <[email protected]> When FPE is not supported by the driver, stmmac_fpe_init() prints a warning but falls through into the pmac_enabled initialization, which should only be reached on supported hardware. Add the missing return to prevent this. Signed-off-by: Rohan G Thomas <[email protected]> Signed-off-by: Nazim Amirul <[email protected]> Reviewed-by: Maxime Chevallier <[email protected]> --- v2: No changes. Collect Reviewed-by from Maxime Chevallier. drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c index 2f880c5e35b0..3436e962a238 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c @@ -174,8 +174,10 @@ void stmmac_fpe_init(struct stmmac_priv *priv) &stmmac_mmsv_ops); if ((!priv->fpe_cfg.reg || !priv->hw->mac->fpe_map_preemption_class) && - priv->dma_cap.fpesel) + priv->dma_cap.fpesel) { dev_info(priv->device, "FPE is not supported by driver.\n"); + return; + } /* The preemptive MAC in DWMAC is always enabled, so initialize * pmac_enabled to true to reflect the hardware state. -- 2.43.7