Re: [PATCH 08/21] dt-bindings: mfd: x-powers: add AC200
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.netdev,dev.linux.lists.linux-sunxi,dev.linux.lists.mfd,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 03/08/2026 10:20, Krzysztof Kozlowski wrote: >>>> --- /dev/null >>>> +++ b/include/dt-bindings/mfd/x-powers,ac200.h >>>> @@ -0,0 +1,13 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>> +/* >>>> + * Interrupt numbers of the X-Powers AC200 interrupt controller. >>>> + */ >>>> + >>>> +#ifndef _DT_BINDINGS_MFD_X_POWERS_AC200_H >>>> +#define _DT_BINDINGS_MFD_X_POWERS_AC200_H >>>> + >>>> +#define AC200_IRQ_TVE 0 >>>> +#define AC200_IRQ_EPHY 1 >>>> +#define AC200_IRQ_RTC 2 >>> >>> Hardware constants are not really bindings, even though you use them in >>> the driver. >> >> Should I do something different for this? > > I would just drop the defines and the header, because these are fixed > hardware numbers. > Hm, unless they are not and you added abstract ID numbers for both DTS and drivers? Then this would be fine. Best regards, Krzysztof